Implement dynamic di #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
force-pushed
the
implement_dynamic_di
branch
from
b7f5ce6
to
f5c1c9c
Compare
vsavkin
force-pushed
the
implement_dynamic_di
branch
2 times, most recently
from
3175a42
to
2c2fb5b
Compare
|
@vojtajina @mhevery: can you review the second commit? Even though the core is working, it is WIP. There are a lot of features that are still missing. |
vsavkin
force-pushed
the
implement_dynamic_di
branch
from
2c2fb5b
to
2369cab
Compare
| @@ -0,0 +1,7 @@ | |||
| //TODO: vsavkin: uncomment once const constructor are supported | |||
|
Very nice! I would get this merge into master and continue on next PR rather than keep fixing this on until it is all done. |
vsavkin
force-pushed
the
implement_dynamic_di
branch
from
2369cab
to
999e848
Compare
vsavkin
force-pushed
the
implement_dynamic_di
branch
from
999e848
to
b219963
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of DI.
Please review only the second commit. The first commit will be gone once #45 is merged.